Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 16658016: Teach rewrite_scoped_ptr_ctor_null about scoped_ptr_malloc's default arg (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Teach rewrite_scoped_ptr_ctor_null about scoped_ptr_malloc's default arg Without filtering out default args, the tool matches the implicit initializers generated for scoped_ptr_malloc<T> members... and then deletes random tokens. Needless to say, the result doesn't compile. BUG=173286 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205700

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M tools/clang/rewrite_scoped_ptr_ctor_null/RewriteScopedPtrCtorNull.cpp View 3 chunks +4 lines, -1 line 0 comments Download
M tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-expected.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Oopsies.
7 years, 6 months ago (2013-06-12 01:55:27 UTC) #1
Nico
lgtm https://codereview.chromium.org/16658016/diff/1/tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc File tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc (right): https://codereview.chromium.org/16658016/diff/1/tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc#newcode29 tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc:29: scoped_ptr_malloc<int> e; One with explicit arg too?
7 years, 6 months ago (2013-06-12 02:40:05 UTC) #2
dcheng
https://codereview.chromium.org/16658016/diff/1/tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc File tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc (right): https://codereview.chromium.org/16658016/diff/1/tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc#newcode29 tools/clang/rewrite_scoped_ptr_ctor_null/tests/test-original.cc:29: scoped_ptr_malloc<int> e; On 2013/06/12 02:40:05, Nico wrote: > One ...
7 years, 6 months ago (2013-06-12 02:57:53 UTC) #3
dcheng
7 years, 6 months ago (2013-06-12 03:03:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r205700.

Powered by Google App Engine
This is Rietveld 408576698