Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: runtime/vm/isolate.cc

Issue 1665773004: Add necessary support functions so that embedders can implemented pause on start and exit (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/message_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index dc99e4c65d4aee132e51ac929e291fd4f1ad6041..2ba8ae05af06d7e83f8c6aad08e010064a5e0476 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1069,8 +1069,6 @@ bool Isolate::MakeRunnable() {
ASSERT(object_store()->root_library() != Library::null());
set_is_runnable(true);
if (!ServiceIsolate::IsServiceIsolate(this)) {
- message_handler()->set_pause_on_start(FLAG_pause_isolates_on_start);
- message_handler()->set_pause_on_exit(FLAG_pause_isolates_on_exit);
if (FLAG_pause_isolates_on_unhandled_exceptions) {
debugger()->SetExceptionPauseInfo(kPauseOnUnhandledExceptions);
}
@@ -1818,13 +1816,13 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
}
jsobj.AddProperty("livePorts", message_handler()->live_ports());
- jsobj.AddProperty("pauseOnExit", message_handler()->pause_on_exit());
+ jsobj.AddProperty("pauseOnExit", message_handler()->should_pause_on_exit());
- if (message_handler()->paused_on_start()) {
+ if (message_handler()->is_paused_on_start()) {
ASSERT(debugger()->PauseEvent() == NULL);
ServiceEvent pause_event(this, ServiceEvent::kPauseStart);
jsobj.AddProperty("pauseEvent", &pause_event);
- } else if (message_handler()->paused_on_exit()) {
+ } else if (message_handler()->is_paused_on_exit()) {
ASSERT(debugger()->PauseEvent() == NULL);
ServiceEvent pause_event(this, ServiceEvent::kPauseExit);
jsobj.AddProperty("pauseEvent", &pause_event);
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/message_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698