Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: runtime/vm/service.cc

Issue 1665773004: Add necessary support functions so that embedders can implemented pause on start and exit (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/message_handler.cc ('K') | « runtime/vm/message_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 24c159842a07daf34ab5c95b57c30f583b0993d6..7a66191ea1153b9d4de83bb7e063686e6f88fcf8 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2965,7 +2965,7 @@ static bool Resume(Thread* thread, JSONStream* js) {
isolate->debugger()->EnterSingleStepMode();
}
isolate->message_handler()->set_pause_on_start(false);
- isolate->set_last_resume_timestamp();
+ isolate->Resume();
if (Service::debug_stream.enabled()) {
ServiceEvent event(isolate, ServiceEvent::kResume);
Service::HandleEvent(&event);
@@ -2975,6 +2975,7 @@ static bool Resume(Thread* thread, JSONStream* js) {
}
if (isolate->message_handler()->paused_on_exit()) {
isolate->message_handler()->set_pause_on_exit(false);
+ isolate->Resume();
turnidge 2016/02/03 21:33:37 Does this send a resume event? Do we want to supp
Cutch 2016/02/03 23:04:05 No it doesn't and I've actually renamed this to be
// We don't send a resume event because we will be exiting.
PrintSuccess(js);
return true;
« runtime/vm/message_handler.cc ('K') | « runtime/vm/message_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698