Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1665753002: depot_tools: add more hacks to properly find build_internal (Closed)

Created:
4 years, 10 months ago by Paweł Hajdan Jr.
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: add more hacks to properly find build_internal I acknowledge this is really gross. This allows us to roll the changes into build_limited in the short term. Longer term, paths could be passed from outside. BUG=582074 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-03 10:43:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665753002/1
4 years, 10 months ago (2016-02-03 10:43:32 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 10:45:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298550

Powered by Google App Engine
This is Rietveld 408576698