Issue 1665743003: Refactor QuicCryptoClientStream to use QuicSession directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1665743003: Refactor QuicCryptoClientStream to use QuicSession directly. (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)

Modified:
4 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, mikescarlett1

Base URL:
https://chromium.googlesource.com/chromium/src.git@113297234

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Refactor QuicCryptoClientStream to use QuicSession directly. Merge internal change: 113372125 R=rch@chromium.org

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -45 lines)			Patch
M	net/quic/quic_client_session_base.h	View	2 chunks	+3 lines, -13 lines	0 comments	Download
M	net/quic/quic_crypto_client_stream.h	View	5 chunks	+27 lines, -7 lines	0 comments	Download
M	net/quic/quic_crypto_client_stream.cc	View	8 chunks	+8 lines, -12 lines	0 comments	Download
M	net/quic/quic_crypto_client_stream_factory.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/mock_crypto_client_stream.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/mock_crypto_client_stream.cc	View	4 chunks	+9 lines, -7 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/quic_client_session.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 3 (0 generated)

ramant (doing other things)

On 2016/02/04 04:35:19, ramant wrote: Hi Ryan, This CL required minor changes to chromium specific ...

4 years, 10 months ago (2016-02-04 04:39:04 UTC) #2

lgtm