Issue 166573003: Port ParentNode API to ElementTraversal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166573003: Port ParentNode API to ElementTraversal (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
adamk, eseidel

CC:
blink-reviews, ed+blinkwatch_opera.com, krit, sof, eae+blinkwatch, fs, dglazkov+blink, f(malita), adamk+blink_chromium.org, gyuyoung.kim_webkit.org, Stephen Chennney, rwlbuis, pdr., Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Port ParentNode API to ElementTraversal Port ParentNode API to ElementTraversal and drop corresponding API on ContainerNode. All callers of the ContainerNode API were updated to use ElementTraversal directly. This is more consistent and avoid inefficiencies due to callers assuming those API methods are simple getters although they need to traverse the DOM tree. It is now obvious to callers that they are traversing the DOM tree and that they should cache the return value. R=adamk, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167226

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -41 lines)			Patch
M	Source/core/dom/ContainerNode.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/dom/ElementTraversal.h	View	2 chunks	+14 lines, -1 line	0 comments	Download
M	Source/core/dom/ParentNode.h	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	Source/core/editing/TypingCommand.cpp	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGPatternElement.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm Those non-cached firstElementChild() were indeed crazy.

6 years, 10 months ago (2014-02-14 19:48:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/166573003/1

6 years, 10 months ago (2014-02-14 20:13:58 UTC) #4

Message was sent while issue was closed.

Change committed as 167226

Expand Messages | Collapse Messages