Issue 166573002: Fake PO2TS GetRequestContext should return NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166573002: Fake PO2TS GetRequestContext should return NULL. (Closed)

Created:
6 years, 10 months ago by msarda

Modified:
6 years, 10 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fake PO2TS GetRequestContext should return NULL. The fake PO2TS does not actually use the request context. This CL overrides the GetRequestContext() in PO2TS and returns NULL to avoid errors like the ones explained at (that occur on iOS) https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/HWdp5roPpF4/j7drB1WW01EJ BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251341

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	chrome/browser/signin/fake_profile_oauth2_token_service.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/signin/fake_profile_oauth2_token_service.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/166573002/1

6 years, 10 months ago (2014-02-14 13:56:45 UTC) #4

Message was sent while issue was closed.

Change committed as 251341