Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1665683002: Revert "Create ElementAnnotation objects prior to resolution." (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Create ElementAnnotation objects prior to resolution." This reverts commit 3977c9f2274df35df6332a65af9973fd6517bc12. The aforementioned commit broke co19 tests involving annotated `part of` directives. It turns out that we can't create the ElementAnnotation objects for annotated `part of` declarations in BuildDirectiveElementsTask, because BuildDirectiveElementsTask is only ever targeted at libraries, therefore it only creates ElementAnnotation objects for annotated directives in defining compilation units. I will follow up with a CL that builds all the ElementAnnotation objects in BuildCompilationUnitElementTask, which runs on all compilation units. TBR=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/36f5c1eeb4e8143702f35ae398191f61daa9d8c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -354 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 22 chunks +3 lines, -112 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +5 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 14 chunks +69 lines, -44 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +9 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +5 lines, -136 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Paul Berry
Committed patchset #1 (id:1) manually as 36f5c1eeb4e8143702f35ae398191f61daa9d8c3 (presubmit successful).
4 years, 10 months ago (2016-02-03 01:55:09 UTC) #2
Brian Wilkerson
4 years, 10 months ago (2016-02-03 14:17:32 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698