Chromium Code Reviews
DescriptionRevert "Create ElementAnnotation objects prior to resolution."
This reverts commit 3977c9f2274df35df6332a65af9973fd6517bc12.
The aforementioned commit broke co19 tests involving annotated `part of`
directives. It turns out that we can't create the ElementAnnotation
objects for annotated `part of` declarations in
BuildDirectiveElementsTask, because BuildDirectiveElementsTask is only
ever targeted at libraries, therefore it only creates ElementAnnotation
objects for annotated directives in defining compilation units.
I will follow up with a CL that builds all the ElementAnnotation objects
in BuildCompilationUnitElementTask, which runs on all compilation units.
TBR=brianwilkerson@google.com
Committed: https://github.com/dart-lang/sdk/commit/36f5c1eeb4e8143702f35ae398191f61daa9d8c3
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||