Issue 16656003: Try to deflake cctest/test-cpu-profiler/NativeAccessorNameInProfile1 on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16656003: Try to deflake cctest/test-cpu-profiler/NativeAccessorNameInProfile1 on Windows (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Try to deflake cctest/test-cpu-profiler/NativeAccessorNameInProfile1 on Windows Make native accessors sleep for 1ms before measuring elapsed time. This is to check the theory that we cannot pause profiled thread on Win64 for some reason and miss many samples. BUG=None TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15016

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	test/cctest/test-cpu-profiler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

Committed patchset #1 manually as r15016 (presubmit successful).

7 years, 6 months ago (2013-06-07 17:25:55 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages