Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1665593002: Add VMUL vector instructions to the integrated ARM assembler. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -19 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 chunks +18 lines, -11 lines 0 comments Download
M tests_lit/assembler/arm32/mul-vec.ll View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 10 months ago (2016-02-02 23:24:21 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1665593002/diff/1/src/IceAssemblerARM32.h File src/IceAssemblerARM32.h (right): https://codereview.chromium.org/1665593002/diff/1/src/IceAssemblerARM32.h#newcode440 src/IceAssemblerARM32.h:440: // Float vector multiply Either end this fragment ...
4 years, 10 months ago (2016-02-02 23:56:56 UTC) #4
Karl
Committed patchset #2 (id:20001) manually as 341158aaa16449090a09dad48c337449d3b4687a (presubmit successful).
4 years, 10 months ago (2016-02-03 21:27:05 UTC) #6
Karl
4 years, 10 months ago (2016-02-03 21:27:32 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1665593002/diff/1/src/IceAssemblerARM32.h
File src/IceAssemblerARM32.h (right):

https://codereview.chromium.org/1665593002/diff/1/src/IceAssemblerARM32.h#new...
src/IceAssemblerARM32.h:440: // Float vector multiply
On 2016/02/02 23:56:56, stichnot wrote:
> Either end this fragment with a period, or remove the period above, whichever
is
> most consistent.

Done.

Powered by Google App Engine
This is Rietveld 408576698