chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc - Issue 1665563003: Ask for notification permission during extension installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

Issue 1665563003: Ask for notification permission during extension installation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/common/extensions/permissions/chrome_permission_message_rules.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

index 5296fbaf088bc14aba565fbcb9a612dfb96c8ce1..418ee51cfe939ce1174e5c3a314c51bd0747beb0 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

@@ -84,10 +84,10 @@ TEST_F(AppInfoPermissionsPanelTest, RequiredPermissionsObtainedCorrectly) {

.Append("desktopCapture") // A valid permission with a

// message

.Append("bad_perm") // An invalid permission

- .Append("notifications") // An valid permission with

+ .Append("cookies") // An valid permission with

// no message

- .Append("serial")))) // Another valid permission with

- // a message

+ .Append("serial")))) // A valid permission with a

+ // message

.SetID(kTestExtensionId)

.Build();

AppInfoPermissionsPanel panel(&profile_, app.get());