android_webview/lib/DEPS - Issue 1665513002: Pass both 32 and 64 bit snapshot and natives fds to child processes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/lib/DEPS

Issue 1665513002: Pass both 32 and 64 bit snapshot and natives fds to child processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+cc/base/switches.h",	2 "+cc/base/switches.h",

3 "+components", # For jni registers.	3 "+components", # For jni registers.

4 "+content/public",	4 "+content/public",

5 "+gin/public",	5 "+gin/public",

	6 "+gin/v8_initializer.h",
	Torne 2016/02/03 11:05:32 This is probably not okay, only headers in public This is probably not okay, only headers in public dirs are supposed to be used by other components. Tobias Sargeant 2016/02/03 11:14:11 I agree, that it looks wrong, but there are plenty Show quoted text On 2016/02/03 11:05:32, Torne wrote: > This is probably not okay, only headers in public dirs are supposed to be used > by other components. I agree, that it looks wrong, but there are plenty of other places that include this header specifically, and apply a specific DEPS rule to do so. It seems like this should actually be public.
6 "+media/base/media_switches.h", # For media command line switches.	7 "+media/base/media_switches.h", # For media command line switches.

7 "+ui/events/gesture_detection",	8 "+ui/events/gesture_detection",

8 "+ui/gl",	9 "+ui/gl",

9 ]	10 ]

OLD	NEW

« no previous file with comments | « no previous file | android_webview/lib/main/aw_main_delegate.cc » ('j') | content/browser/child_process_launcher.cc » ('J')