Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/cronet/url_request_context_config_unittest.cc

Issue 1665503002: [Cronet] Expose quic_user_agent_id and quic_prefer_aes config options. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Document QUIC UAID string usage, don't pass it down unless QUIC is enabled. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/url_request_context_config.cc ('k') | net/url_request/url_request_context_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/url_request_context_config_unittest.cc
diff --git a/components/cronet/url_request_context_config_unittest.cc b/components/cronet/url_request_context_config_unittest.cc
index f309e25a9e930339753ecdb62ff790362cd8484c..b140c34eab5512e586bca07dab4da3a8e2a220c6 100644
--- a/components/cronet/url_request_context_config_unittest.cc
+++ b/components/cronet/url_request_context_config_unittest.cc
@@ -19,6 +19,8 @@ TEST(URLRequestContextConfigTest, SetQuicExperimentalOptions) {
URLRequestContextConfig config(
// Enable QUIC.
true,
+ // QUIC User Agent ID.
+ "Default QUIC User Agent ID",
// Enable SPDY.
true,
// Enable SDCH.
@@ -38,6 +40,8 @@ TEST(URLRequestContextConfigTest, SetQuicExperimentalOptions) {
"{\"QUIC\":{\"max_server_configs_stored_in_properties\":2,"
"\"delay_tcp_race\":true,"
"\"max_number_of_lossy_connections\":10,"
+ "\"prefer_aes\":true,"
+ "\"user_agent_id\":\"Custom QUIC UAID\","
"\"packet_loss_threshold\":0.5,"
"\"idle_connection_timeout_seconds\":300,"
"\"close_sessions_on_ip_change\":true,"
@@ -71,12 +75,18 @@ TEST(URLRequestContextConfigTest, SetQuicExperimentalOptions) {
quic_connection_options.push_back(net::kREJ);
EXPECT_EQ(quic_connection_options, params->quic_connection_options);
+ // Check Custom QUIC User Agent Id.
+ EXPECT_EQ("Custom QUIC UAID", params->quic_user_agent_id);
+
// Check max_server_configs_stored_in_properties.
EXPECT_EQ(2u, params->quic_max_server_configs_stored_in_properties);
// Check delay_tcp_race.
EXPECT_TRUE(params->quic_delay_tcp_race);
+ // Check prefer_aes.
+ EXPECT_TRUE(params->quic_prefer_aes);
+
// Check max_number_of_lossy_connections and packet_loss_threshold.
EXPECT_EQ(10, params->quic_max_number_of_lossy_connections);
EXPECT_FLOAT_EQ(0.5f, params->quic_packet_loss_threshold);
« no previous file with comments | « components/cronet/url_request_context_config.cc ('k') | net/url_request/url_request_context_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698