Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: components/cronet/android/test/cronet_url_request_context_config_test.cc

Issue 1665503002: [Cronet] Expose quic_user_agent_id and quic_prefer_aes config options. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Document QUIC UAID string usage, don't pass it down unless QUIC is enabled. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/cronet_url_request_context_config_test.cc
diff --git a/components/cronet/android/test/cronet_url_request_context_config_test.cc b/components/cronet/android/test/cronet_url_request_context_config_test.cc
index c879fe97fd78d41f0117f9276893200016f51169..d3156c0e5342db351ca9f8c7f491fbac37c29fd9 100644
--- a/components/cronet/android/test/cronet_url_request_context_config_test.cc
+++ b/components/cronet/android/test/cronet_url_request_context_config_test.cc
@@ -11,6 +11,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/logging.h"
#include "components/cronet/url_request_context_config.h"
+#include "components/cronet/version.h"
#include "jni/CronetUrlRequestContextTest_jni.h"
namespace cronet {
@@ -32,6 +33,8 @@ static void VerifyUrlRequestContextConfig(
CHECK_EQ((*config->quic_hints.begin())->host, "example.com");
CHECK_EQ((*config->quic_hints.begin())->port, 12);
CHECK_EQ((*config->quic_hints.begin())->alternate_port, 34);
+ CHECK_NE(config->quic_user_agent_id.find("Cronet/" CRONET_VERSION),
+ std::string::npos);
CHECK_EQ(config->load_disable_cache, false);
CHECK_EQ(config->http_cache, URLRequestContextConfig::HttpCacheType::MEMORY);
CHECK_EQ(config->http_cache_max_size, 54321);
@@ -49,4 +52,4 @@ bool RegisterCronetUrlRequestContextConfigTest(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-} // namespace cronet
+} // namespace cronet

Powered by Google App Engine
This is Rietveld 408576698