[Line Layout API] Add LineLayoutSVGInline and LineLayoutSVGTextPath

[Line Layout API] Add LineLayoutSVGInline and LineLayoutSVGTextPath

These proxy LayoutSVGInline and LayoutSVGTextPath, respectively.
The LineLayoutSVGInline class currently has no proxied methods, but
it is an ancestor for LineLayoutSVGTextPath, which has two new
proxied methods, layoutPath() and calculateStartOffset(). Both
methods are called from SVGTextLayoutEngine.

There are no functional changes.

BUG=499321
TBR=leviw

Committed: https://crrev.com/14de694796aae7376d74bd88ba7118fc6c6840b2
Cr-Commit-Position: refs/heads/master@{#374784}

[pilgrim_google, 2016-02-05 16:25:15]

pilgrim@chromium.org changed reviewers:
+ eae@chromium.org, jsbell@chromium.org, leviw@chromium.org, ojan@chromium.org

[leviw_travelin_and_unemployed, 2016-02-08 08:09:48]

https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/api/LineLayoutSVGInline.h (right):

https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/api/LineLayoutSVGInline.h:13: class
LineLayoutSVGInline : public LineLayoutInline {
Is there an expectation that methods will end up here later?

https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp (right):

https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp:194: if
(SVGTextContentElement* textContentElement =
SVGTextContentElement::elementFromLayoutObject(LineLayoutAPIShim::layoutObjectFrom(textPath)))
{
It'd be good to push this down and rename
SVGTextContentElement::elementFromLayoutObject to elementFromLineLayoutItem.

[pilgrim_google, 2016-02-09 18:46:37]

On 2016/02/08 at 08:09:48, leviw wrote:
>
https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/api/LineLayoutSVGInline.h (right):
> 
>
https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/api/LineLayoutSVGInline.h:13: class
LineLayoutSVGInline : public LineLayoutInline {
> Is there an expectation that methods will end up here later?
> 

Yes, a firstLineBox() method which is used from SVGTextQuery.

>
https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
(right):
> 
>
https://codereview.chromium.org/1665413003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp:194: if
(SVGTextContentElement* textContentElement =
SVGTextContentElement::elementFromLayoutObject(LineLayoutAPIShim::layoutObjectFrom(textPath)))
{
> It'd be good to push this down and rename
SVGTextContentElement::elementFromLayoutObject to elementFromLineLayoutItem.

I promise to do this in a followup CL.

[pilgrim_google, 2016-02-10 15:14:16]

Description was changed from

==========
[Line Layout API] Add LineLayoutSVGInline and LineLayoutSVGTextPath

These proxy LayoutSVGInline and LayoutSVGTextPath, respectively.
The LineLayoutSVGInline class currently has no proxied methods, but
it is an ancestor for LineLayoutSVGTextPath, which has two new
proxied methods, layoutPath() and calculateStartOffset(). Both
methods are called from SVGTextLayoutEngine.

There are no functional changes.

BUG=499321
==========

to

==========
[Line Layout API] Add LineLayoutSVGInline and LineLayoutSVGTextPath

These proxy LayoutSVGInline and LayoutSVGTextPath, respectively.
The LineLayoutSVGInline class currently has no proxied methods, but
it is an ancestor for LineLayoutSVGTextPath, which has two new
proxied methods, layoutPath() and calculateStartOffset(). Both
methods are called from SVGTextLayoutEngine.

There are no functional changes.

BUG=499321
TBR=leviw
==========

[pilgrim_google, 2016-02-10 15:14:20]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-02-10 15:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1665413003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1665413003/20001

[commit-bot: I haz the power, 2016-02-10 19:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 19:11:22]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pilgrim_google, 2016-02-10 20:09:07]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-02-10 20:10:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1665413003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1665413003/20001

[commit-bot: I haz the power, 2016-02-10 23:40:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:32:39]

Description was changed from

==========
[Line Layout API] Add LineLayoutSVGInline and LineLayoutSVGTextPath

These proxy LayoutSVGInline and LayoutSVGTextPath, respectively.
The LineLayoutSVGInline class currently has no proxied methods, but
it is an ancestor for LineLayoutSVGTextPath, which has two new
proxied methods, layoutPath() and calculateStartOffset(). Both
methods are called from SVGTextLayoutEngine.

There are no functional changes.

BUG=499321
TBR=leviw
==========

to

==========
[Line Layout API] Add LineLayoutSVGInline and LineLayoutSVGTextPath

These proxy LayoutSVGInline and LayoutSVGTextPath, respectively.
The LineLayoutSVGInline class currently has no proxied methods, but
it is an ancestor for LineLayoutSVGTextPath, which has two new
proxied methods, layoutPath() and calculateStartOffset(). Both
methods are called from SVGTextLayoutEngine.

There are no functional changes.

BUG=499321
TBR=leviw

Committed: https://crrev.com/14de694796aae7376d74bd88ba7118fc6c6840b2
Cr-Commit-Position: refs/heads/master@{#374784}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:40]

Patchset 2 (id:??) landed as
https://crrev.com/14de694796aae7376d74bd88ba7118fc6c6840b2
Cr-Commit-Position: refs/heads/master@{#374784}