chrome/common/safe_browsing/protobuf_message_param_traits.h - Issue 1665363002: Clang plugin to check that unstable types are not used in IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/protobuf_message_param_traits.h

Issue 1665363002: Clang plugin to check that unstable types are not used in IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typos Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/safe_browsing/protobuf_message_param_traits.h

diff --git a/chrome/common/safe_browsing/protobuf_message_param_traits.h b/chrome/common/safe_browsing/protobuf_message_param_traits.h

index a935584d0d85edba03c0ba5edc01c6886a282db8..7d78c6cb53309f0e07fcec51b07238ebcbbcdda7 100644

--- a/chrome/common/safe_browsing/protobuf_message_param_traits.h

+++ b/chrome/common/safe_browsing/protobuf_message_param_traits.h

@@ -21,9 +21,9 @@ struct ParamTraits<google::protobuf::RepeatedPtrField<Element>> {

typedef google::protobuf::RepeatedPtrField<Element> param_type;

static void Write(base::Pickle* m, const param_type& p) {

- WriteParam(m, p.size());

+ WriteParam(m, static_cast<int>(p.size()));

for (const auto& element : p)

- WriteParam(m, element);

+ WriteParam<Element>(m, element);

}

static bool Read(const base::Pickle* m,

« no previous file with comments | « build/config/clang/BUILD.gn ('k') | gpu/ipc/id_type_traits.h » ('j') | tools/clang/plugins/CheckIPCVisitor.h » ('J')