build/common.gypi - Issue 1665363002: Clang plugin to check that unstable types are not used in IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1665363002: Clang plugin to check that unstable types are not used in IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Blacklist types instead Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index fdeac0b91fe37ea7ef953bcccc912bc2c553f46d..c56e42d7b0b9f982e691f09c883dd77113d65dc3 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2228,6 +2228,11 @@

# no need to load it dynamically.

'clang_dynlib_flags%': '',

}],

+ ['OS=="android"', {

+ 'clang_plugin_args_ipc%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc',

+ }, {

+ 'clang_plugin_args_ipc%': '',

+ }],

'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates '

'-Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion ',

@@ -2235,7 +2240,7 @@

# If you change these, also change build/config/clang/BUILD.gn.

'clang_chrome_plugins_flags%':

'<(clang_dynlib_flags)'

- '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)',

+ '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args) <(clang_plugin_args_ipc)',

}],

['asan==1 or msan==1 or lsan==1 or tsan==1', {

'clang%': 1,

« no previous file with comments | « no previous file | build/config/clang/BUILD.gn » ('j') | ipc/ipc_message_utils.h » ('J')