Clang plugin to check that unstable types are not used in IPC.

tools/clang/plugins/FindBadConstructsConsumer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a bunch of recurring problems in the Chromium C++ code.
 //
 // Checks that are implemented:
 // - Constructors/Destructors should not be inlined if they are of a complex
 //   class type.
 // - Missing "virtual" keywords on methods that should be virtual.
 // - Non-annotated overriding virtual methods.
 // - Virtual methods with nonempty implementations in their headers.
 // - Classes that derive from base::RefCounted / base::RefCountedThreadSafe
 //   should have protected or private destructors.
 // - WeakPtrFactory members that refer to their outer class should be the last
 //   member.
 // - Enum types with a xxxx_LAST or xxxxLast const actually have that constant
 //   have the maximal value for that type.
 
 #ifndef TOOLS_CLANG_PLUGINS_FINDBADCONSTRUCTSCONSUMER_H_
 #define TOOLS_CLANG_PLUGINS_FINDBADCONSTRUCTSCONSUMER_H_
 
+#include <memory>
+
 #include "clang/AST/AST.h"
 #include "clang/AST/ASTConsumer.h"
 #include "clang/AST/Attr.h"
 #include "clang/AST/CXXInheritance.h"
 #include "clang/AST/RecursiveASTVisitor.h"
 #include "clang/AST/TypeLoc.h"
 #include "clang/Basic/SourceManager.h"
 #include "clang/Basic/SourceLocation.h"
 
+#include "CheckIPCVisitor.h"
 #include "ChromeClassTester.h"
 #include "Options.h"
 #include "SuppressibleDiagnosticBuilder.h"
 
 namespace chrome_checker {
 
 // Searches for constructs that we know we don't want in the Chromium code base.
 class FindBadConstructsConsumer
     : public clang::RecursiveASTVisitor<FindBadConstructsConsumer>,
       public ChromeClassTester {
  public:
   FindBadConstructsConsumer(clang::CompilerInstance& instance,
                             const Options& options);
 
+  void Visit(clang::ASTContext& context);

[dcheng, 2016/03/07 23:44:39]

Nit: Traverse() for consistency with RecursiveASTVisitor's naming scheme.

[Dmitry Skiba, 2016/03/08 01:16:11]

Done.

+
   // RecursiveASTVisitor:
+  bool shouldVisitTemplateInstantiations() const;
+  bool TraverseDecl(clang::Decl* decl);
   bool VisitDecl(clang::Decl* decl);
+  bool VisitTemplateSpecializationType(clang::TemplateSpecializationType* spec);
+  bool VisitCallExpr(clang::CallExpr* call_expr);
 
   // ChromeClassTester overrides:
   void CheckChromeClass(clang::SourceLocation record_location,
                         clang::CXXRecordDecl* record) override;
   void CheckChromeEnum(clang::SourceLocation enum_location,
                        clang::EnumDecl* enum_decl) override;
 
  private:
   // The type of problematic ref-counting pattern that was encountered.
   enum RefcountIssue { None, ImplicitDestructor, PublicDestructor };
@@ skipping 45 matching lines @@
   unsigned diag_base_method_virtual_and_final_;
   unsigned diag_no_explicit_dtor_;
   unsigned diag_public_dtor_;
   unsigned diag_protected_non_virtual_dtor_;
   unsigned diag_weak_ptr_factory_order_;
   unsigned diag_bad_enum_last_value_;
   unsigned diag_note_inheritance_;
   unsigned diag_note_implicit_dtor_;
   unsigned diag_note_public_dtor_;
   unsigned diag_note_protected_non_virtual_dtor_;
+
+  std::unique_ptr<CheckIPCVisitor> ipc_visitor_;
 };
 
 }  // namespace chrome_checker
 
 #endif  // TOOLS_CLANG_PLUGINS_FINDBADCONSTRUCTSCONSUMER_H_