pkg/analyzer/lib/src/task/dart.dart - Issue 1665353002: Use ElementAnnotation as the ConstantEvaluationTarget for annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1665353002: Use ElementAnnotation as the ConstantEvaluationTarget for annotations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/task/dart.dart

diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart

index e1063c35726645826cbb84319739270fe8857f62..800573b2e914b585768ede62a87f86af1fa4c292 100644

--- a/pkg/analyzer/lib/src/task/dart.dart

+++ b/pkg/analyzer/lib/src/task/dart.dart

@@ -1669,7 +1669,7 @@ class ComputeConstantDependenciesTask extends ConstantEvaluationAnalysisTask {

CompilationUnitElementImpl unit = target

.getAncestor((Element element) => element is CompilationUnitElement);

librarySource = unit.librarySource;

- } else if (target is ConstantEvaluationTarget_Annotation) {

+ } else if (target is ElementAnnotationImpl) {

librarySource = target.librarySource;

} else {

throw new AnalysisException(

« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/test/generated/constant_test.dart » ('j') | no next file with comments »