Add message and Help Center link to the chooser UI for Mac

Add message and Help Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get
help" at the bottom of the chooser UI, and the "Get help"
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
Committed: https://crrev.com/5b45dd0879a8a43ef1d0183a1fa13677a9af6900
Cr-Commit-Position: refs/heads/master@{#377949}

[juncai, 2016-02-04 23:05:11]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org

[juncai, 2016-02-04 23:05:11]

Please review this patch.

[Robert Sesek, 2016-02-04 23:11:59]

https://codereview.chromium.org/1665343003/diff/1/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1665343003/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:55: }
Add a missing "  // namespace" comment here.

https://codereview.chromium.org/1665343003/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:465: -
(base::scoped_nsobject<NSBox>)separator {
Can you use -[BaseBubbleController horizontalSeparatorWithFrame:] ?

[juncai, 2016-02-05 00:20:41]

https://codereview.chromium.org/1665343003/diff/1/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1665343003/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:55: }
On 2016/02/04 23:11:59, Robert Sesek wrote:
> Add a missing "  // namespace" comment here.

Done.

https://codereview.chromium.org/1665343003/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:465: -
(base::scoped_nsobject<NSBox>)separator {
On 2016/02/04 23:11:59, Robert Sesek wrote:
> Can you use -[BaseBubbleController horizontalSeparatorWithFrame:] ?

Done.

[Robert Sesek, 2016-02-05 00:22:19]

lgtm

[juncai, 2016-02-12 22:01:39]

Description was changed from

==========
Add privacy message to the chooser UI for Mac

This patch added privacy message to the chooser UI for Mac. The message
is added below the "Connect" and "Cancel" button with a grey separator.

BUG=492204, 583479
==========

to

==========
Add message and Helper Center link to the chooser UI for Mac

This patch added privacy message to the chooser UI for Mac. The message
is added below the "Connect" and "Cancel" button with a grey separator.

BUG=492204, 583479
==========

[juncai, 2016-02-12 22:03:01]

Description was changed from

==========
Add message and Helper Center link to the chooser UI for Mac

This patch added privacy message to the chooser UI for Mac. The message
is added below the "Connect" and "Cancel" button with a grey separator.

BUG=492204, 583479
==========

to

==========
Add message and Helper Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get help"
at the bottom of the chooser UI, and the "Get help" links
to a Helper Center URL. The message is added below the
"Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

[juncai, 2016-02-12 22:03:56]

Description was changed from

==========
Add message and Helper Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get help"
at the bottom of the chooser UI, and the "Get help" links
to a Helper Center URL. The message is added below the
"Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

to

==========
Add message and Helper Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get 
help." at the bottom of the chooser UI, and the "Get help."
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

[juncai, 2016-02-16 18:37:42]

Instead of displaying some text, now the chooser UI displays "Not seeing your
device? Get help." at the bottom, the "Get help" is a link to Helper Center
article. It is suggested by UI team at issue:
https://code.google.com/p/chromium/issues/detail?id=583479
There is also a screenshot on Linux posted there.

Please review the change.

[Robert Sesek, 2016-02-16 21:26:40]

https://codereview.chromium.org/1665343003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1665343003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:500:
[helpTextView addLinkRange:NSMakeRange(getHelpOffset, [getHelpText length])
Since you're linkifying the entire text content, did you look at
HyperlinkButtonCell ?

[juncai, 2016-02-17 01:06:42]

https://codereview.chromium.org/1665343003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
(right):

https://codereview.chromium.org/1665343003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:500:
[helpTextView addLinkRange:NSMakeRange(getHelpOffset, [getHelpText length])
On 2016/02/16 21:26:40, Robert Sesek wrote:
> Since you're linkifying the entire text content, did you look at
> HyperlinkButtonCell ?

Done.

[Robert Sesek, 2016-02-17 22:22:57]

lgtm

[juncai, 2016-02-18 04:46:56]

Description was changed from

==========
Add message and Helper Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get 
help." at the bottom of the chooser UI, and the "Get help."
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

to

==========
Add message and Help Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get 
help" at the bottom of the chooser UI, and the "Get help"
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

[juncai, 2016-02-24 04:29:28]

Hi Robert, would you mind reviewing this patch again? Since this patch depends
on:
https://codereview.chromium.org/1661063002
And there was some code change in the above patch, so I use HyperlinkTextView in
this patch.

Thanks a lot!

[juncai, 2016-02-26 18:53:43]

kindly ping, :), would like to push this patch before M50 branch release. Thanks
a lot!

[Robert Sesek, 2016-02-26 18:57:57]

LGTM. Sorry for the delay, was traveling yesterday.

[juncai, 2016-02-26 19:01:47]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-02-26 19:03:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1665343003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1665343003/100001

[commit-bot: I haz the power, 2016-02-26 20:01:06]

Description was changed from

==========
Add message and Help Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get 
help" at the bottom of the chooser UI, and the "Get help"
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

to

==========
Add message and Help Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get 
help" at the bottom of the chooser UI, and the "Get help"
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

[commit-bot: I haz the power, 2016-02-26 20:01:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-26 20:02:01]

Description was changed from

==========
Add message and Help Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get 
help" at the bottom of the chooser UI, and the "Get help"
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479
==========

to

==========
Add message and Help Center link to the chooser UI for Mac

This patch added message "Not seeing your device? Get
help" at the bottom of the chooser UI, and the "Get help"
links to a Helper Center URL. The message is added below
the "Connect" and "Cancel" button with a grey separator.

This is a follow-up patch for:
https://codereview.chromium.org/1661063002/

BUG=492204, 583479

Committed: https://crrev.com/5b45dd0879a8a43ef1d0183a1fa13677a9af6900
Cr-Commit-Position: refs/heads/master@{#377949}
==========

[commit-bot: I haz the power, 2016-02-26 20:02:02]

Patchset 6 (id:??) landed as
https://crrev.com/5b45dd0879a8a43ef1d0183a1fa13677a9af6900
Cr-Commit-Position: refs/heads/master@{#377949}