Clean up assembling MOV instructions in the integrated ARM assembler.

Clean up assembling MOV instructions in the integrated ARM assembler.

Flattens out MOV's emitIAS methods making it easier to see valid types
for source/destination of the move.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=282d7afd1216597de73a2ef47b9669747260fdf2

[Karl, 2016-02-04 22:06:24]

Description was changed from

==========
Clean up assembling MOV instructions in the integrated ARM assembler.

Flattens out MOV's emitIAS methods making it easier to see valid types
for source/destination of the move.

BUG=None
==========

to

==========
Clean up assembling MOV instructions in the integrated ARM assembler.

Flattens out MOV's emitIAS methods making it easier to see valid types
for source/destination of the move.

BUG=None
==========

[Karl, 2016-02-04 22:06:24]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-02-05 00:56:23]

lgtm

https://codereview.chromium.org/1665323002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1665323002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1298: case IceType_void:
Consider just using "default:", for symmetry with the inner "switch (SrcTy)"
statements.

https://codereview.chromium.org/1665323002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1329: } else if (const auto *FpImm =
Don't use "else if" after a clause that ends with a return.

Here and below.

[Karl, 2016-02-05 15:26:47]

Description was changed from

==========
Clean up assembling MOV instructions in the integrated ARM assembler.

Flattens out MOV's emitIAS methods making it easier to see valid types
for source/destination of the move.

BUG=None
==========

to

==========
Clean up assembling MOV instructions in the integrated ARM assembler.

Flattens out MOV's emitIAS methods making it easier to see valid types
for source/destination of the move.

BUG=None
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-02-05 15:26:48]

Committed patchset #3 (id:40001) manually as
282d7afd1216597de73a2ef47b9669747260fdf2 (presubmit successful).

[Karl, 2016-02-05 15:27:09]

https://codereview.chromium.org/1665323002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1665323002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1298: case IceType_void:
On 2016/02/05 00:56:23, stichnot wrote:
> Consider just using "default:", for symmetry with the inner "switch (SrcTy)"
> statements.

Done.

https://codereview.chromium.org/1665323002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1329: } else if (const auto *FpImm =
On 2016/02/05 00:56:23, stichnot wrote:
> Don't use "else if" after a clause that ends with a return.
> 
> Here and below.

Done.