Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1665283002: Test that ElementBuilder handles DefaultFormalParameter properly. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test that ElementBuilder handles DefaultFormalParameter properly. These test cases were accidentally left out of commit 50248829053444be8299e19c342d0bb348506e3a. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/1b4e04885607383af2e8f9ebcf16de285fc0dbd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-04 21:06:19 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-04 21:31:45 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-04 22:04:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b4e04885607383af2e8f9ebcf16de285fc0dbd6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698