src/IceTargetLowering.cpp - Issue 1665263003: Subzero. ARM32. Nonsfi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLowering.cpp

Issue 1665263003: Subzero. ARM32. Nonsfi. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLowering.cpp

diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp

index 75886d6dd8997693d240c6e878ec52f416402358..f72d2a02852f8a537664c95e015f2b0a1efaa50c 100644

--- a/src/IceTargetLowering.cpp

+++ b/src/IceTargetLowering.cpp

@@ -864,6 +864,10 @@ void TargetDataLowering::emitGlobal(const VariableDeclaration &Var,

llvm::cast<VariableDeclaration::RelocInitializer>(Init.get());

Str << "\t" << getEmit32Directive() << "\t";

Str << Reloc->getDeclaration()->mangleName(Ctx);

+ if (Reloc->hasFixup()) {

+ // TODO(jpp): this is ARM32 specific.

+ Str << "(GOTOFF)";

+ }

if (RelocOffsetT Offset = Reloc->getOffset()) {

if (Offset >= 0 || (Offset == INT32_MIN))

Str << " + " << Offset;