Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/IceTargetLowering.cpp

Issue 1665263003: Subzero. ARM32. Nonsfi. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: git pull Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceELFObjectWriter.cpp ('K') | « src/IceOperand.cpp ('k') | src/IceTargetLoweringARM32.h » ('j') | src/IceTargetLoweringARM32.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLowering.cpp
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index d53fbab4e12a01d8179d97bbc3cce298e7ac7fc8..544dfb1a7216dd8ecdbbce36d52774a5acb4c045 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -831,6 +831,10 @@ void TargetDataLowering::emitGlobal(const VariableDeclaration &Var,
llvm::cast<VariableDeclaration::RelocInitializer>(Init.get());
Str << "\t" << getEmit32Directive() << "\t";
Str << Reloc->getDeclaration()->mangleName(Ctx);
+ if (Reloc->hasFixup()) {
+ // TODO(jpp): this is ARM32 specific.
+ Str << "(GOTOFF)";
+ }
if (RelocOffsetT Offset = Reloc->getOffset()) {
if (Offset >= 0 || (Offset == INT32_MIN))
Str << " + " << Offset;
« src/IceELFObjectWriter.cpp ('K') | « src/IceOperand.cpp ('k') | src/IceTargetLoweringARM32.h » ('j') | src/IceTargetLoweringARM32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698