Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1665233002: presubmit: add depot_tools to PATH (Closed)

Created:
4 years, 10 months ago by Paweł Hajdan Jr.
Modified:
4 years, 10 months ago
Reviewers:
M-A Ruel, rmistry1
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

presubmit: add depot_tools to PATH BUG=584197 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M recipe_modules/presubmit/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M recipe_modules/presubmit/api.py View 1 chunk +7 lines, -0 lines 0 comments Download
M recipe_modules/presubmit/example.expected/basic.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Paweł Hajdan Jr.
This prevents the following error on swarming: https://chromium-swarm.appspot.com/user/task/2cc651dce7554910 Traceback (most recent call last): File "scripts/master/unittests/gclient_source_test.py", ...
4 years, 10 months ago (2016-02-04 18:31:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665233002/1
4 years, 10 months ago (2016-02-04 18:32:47 UTC) #4
rmistry1
lgtm
4 years, 10 months ago (2016-02-04 18:34:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 18:34:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665233002/1
4 years, 10 months ago (2016-02-04 21:27:53 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 21:30:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298599

Powered by Google App Engine
This is Rietveld 408576698