Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 166513003: Remove Parser::scanner(). There is already ParserBase::scanner(). (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Remove Parser::scanner(). There is already ParserBase::scanner(). R=ulan@chromium.org BUG=v8:3126 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -59 lines) Patch
M src/parser.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/parser.cc View 42 chunks +55 lines, -55 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal
6 years, 10 months ago (2014-02-14 11:30:15 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-14 12:12:13 UTC) #2
marja
6 years, 10 months ago (2014-02-14 12:13:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698