build/common.gypi - Issue 166513002: Revert of Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 166513002: Revert of Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 015d44100a0f8b93362eae7f533a1b95e43bde88..16c5abe9727c56c42e40b744ecd983fb4cdbdf3f 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1332,8 +1332,10 @@

# can use breakpad for these builds.

'release_unwind_tables%': 0,

}],

- # TODO(jungshik): Turn this on on Android and Chrome OS

- ['OS!="android" and chromeos==0', {

+ # TODO(jungshik): Turn this on on Android.

+ # For ChromeOS, this should be turned on in chromeos-chrome.ebuild

+ # file as well by adding icu_use_data_file_flag=1 to BUILD_DEFINES.

+ ['OS!="android"', {

'icu_use_data_file_flag%': 1,

}],

« no previous file with comments | « no previous file | no next file » | no next file with comments »