Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1665113004: Update timezone db and add minimal locale data for ast,an, and wa. (Closed)

Created:
4 years, 10 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update timezone db and add minimal locale data for ast,an, and wa. 1. ast,an,wa locale data (minimal) - make up the minimal locale data for 3 languages. - update source/data/{locale,lang}/reslocal.mk to have 3 languages - update scripts/data_file_to_preserve.txt to have files for 3 locales listed. - In chromium, these languages have to be added to the A-L list to show up in the A-L pull-down in settings. 2. IANA timezone db updte to 2016a See http://mm.icann.org/pipermail/tz-announce/2016-January/000035.html for the change. 3. Pre-built-data files are updated. Data (icudtl.dat) size changes between 54.1 and 56.1 non-Android platforms: 10,124,096 bytes (net change: -83,840) Android: 6,560,080 bytes (net change: +291,840 / 4.66%) BUG=575007, 474333 R=jsbell@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/4d467e4e3433fc0a307b2210b4a18370ec4301f8

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1448 lines, -1342 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M android/icudtl.dat View Binary file 0 comments Download
M scripts/accept_lang.list View 2 chunks +3 lines, -0 lines 0 comments Download
M scripts/data_files_to_preserve.txt View 1 chunk +8 lines, -2 lines 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
A + source/data/lang/an.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + source/data/lang/ast.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/lang/reslocal.mk View 2 chunks +3 lines, -0 lines 0 comments Download
A + source/data/lang/wa.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A source/data/locales/an.txt View 1 chunk +17 lines, -0 lines 2 comments Download
A source/data/locales/ast.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M source/data/locales/reslocal.mk View 2 chunks +3 lines, -0 lines 0 comments Download
A source/data/locales/wa.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M source/data/misc/metaZones.txt View 6 chunks +33 lines, -1 line 0 comments Download
M source/data/misc/timezoneTypes.txt View 1 chunk +1 line, -0 lines 0 comments Download
M source/data/misc/windowsZones.txt View 10 chunks +17 lines, -13 lines 0 comments Download
M source/data/misc/zoneinfo64.txt View 150 chunks +1322 lines, -1319 lines 0 comments Download
M windows/icudt.dll View Binary file 0 comments Download

Messages

Total messages: 9 (5 generated)
jungshik at Google
PTAL/FYI. Thanks.
4 years, 10 months ago (2016-02-04 20:12:45 UTC) #3
jsbell
lgtm with comment nit https://codereview.chromium.org/1665113004/diff/1/source/data/locales/an.txt File source/data/locales/an.txt (right): https://codereview.chromium.org/1665113004/diff/1/source/data/locales/an.txt#newcode9 source/data/locales/an.txt:9: * Accept-Language menu and. ExemplarCharacters ...
4 years, 10 months ago (2016-02-04 20:16:18 UTC) #4
jungshik at Google
Committed patchset #1 (id:1) manually as 4d467e4e3433fc0a307b2210b4a18370ec4301f8 (presubmit successful).
4 years, 10 months ago (2016-02-04 22:21:20 UTC) #8
jungshik at Google
4 years, 10 months ago (2016-02-05 00:55:47 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1665113004/diff/1/source/data/locales/an.txt
File source/data/locales/an.txt (right):

https://codereview.chromium.org/1665113004/diff/1/source/data/locales/an.txt#...
source/data/locales/an.txt:9: *  Accept-Language menu and. ExemplarCharacters
field is based on
On 2016/02/04 20:16:18, jsbell wrote:
> Nit: either "and" or the "." should be removed.

Fixed and landed. Thanks

Powered by Google App Engine
This is Rietveld 408576698