Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: src/caterpillar_test.py

Issue 1665103002: Removed replacing double- with single-quotes in app.info generation. Resolves #40. (Closed) Base URL: https://github.com/chromium/caterpillar.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/caterpillar.py ('k') | tests/test_app_tts_output/app.info.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/caterpillar_test.py
diff --git a/src/caterpillar_test.py b/src/caterpillar_test.py
index 6952c6699ed4d7b81cd67976e466a7dc62837275..4c645193b54b82f11c8899e31014d3aa45cf22a7 100755
--- a/src/caterpillar_test.py
+++ b/src/caterpillar_test.py
@@ -687,7 +687,7 @@ class TestAddAppInfo(TestCaseWithOutputDir):
"""Tests add_app_info writes the correct file."""
chrome_app_manifest = {
'app': {'background': {}},
- 'name': 'tést app',
+ 'name': 'tést app\'',
Matt Giuca 2016/02/04 05:12:28 Good!
}
caterpillar.add_app_info(self.output_path, chrome_app_manifest)
@@ -697,10 +697,10 @@ class TestAddAppInfo(TestCaseWithOutputDir):
self.assertEqual(app_info_js, """\
chrome.caterpillar.manifest = {
- 'app': {
- 'background': {}
+ "app": {
+ "background": {}
},
- 'name': 't\\u00e9st app'
+ "name": "t\\u00e9st app'"
};
""")
« no previous file with comments | « src/caterpillar.py ('k') | tests/test_app_tts_output/app.info.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698