Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1665103002: Removed replacing double- with single-quotes in app.info generation. Resolves #40. (Closed)

Created:
4 years, 10 months ago by Matthew Alger
Modified:
4 years, 10 months ago
Reviewers:
Matt Giuca
CC:
raymes
Base URL:
https://github.com/chromium/caterpillar.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed replacing double- with single-quotes in app.info generation. Resolves #40. https://github.com/chromium/caterpillar/issues/40 R=mgiuca@chromium.org Committed: 2e5291a0f4756d82e835b29f338689ba3232d438

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/caterpillar.py View 1 chunk +1 line, -1 line 0 comments Download
M src/caterpillar_test.py View 2 chunks +4 lines, -4 lines 1 comment Download
M tests/test_app_tts_output/app.info.js View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Matthew Alger
4 years, 10 months ago (2016-02-04 03:50:48 UTC) #2
Matt Giuca
lgtm https://codereview.chromium.org/1665103002/diff/1/src/caterpillar_test.py File src/caterpillar_test.py (right): https://codereview.chromium.org/1665103002/diff/1/src/caterpillar_test.py#newcode690 src/caterpillar_test.py:690: 'name': 'tést app\'', Good!
4 years, 10 months ago (2016-02-04 05:12:28 UTC) #3
Matthew Alger
4 years, 10 months ago (2016-02-04 05:46:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2e5291a0f4756d82e835b29f338689ba3232d438 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698