Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 166503002: Test and fix for polymorphic named call deoptimization. (Closed)

Created:
6 years, 10 months ago by Jarin
Modified:
6 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Test and fix for polymorphic named call deoptimization. The fix removes wrong simulates from the number branch of polymorphic call/field access handling. The change also fixes the same thing for polymorphic named field access even thourgh the field access is probably safe in practice (because it cannot deoptimize). It is better to keep all our simulates in sync with full codegen. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/hydrogen.cc View 4 chunks +4 lines, -6 lines 0 comments Download
A + test/mjsunit/regress/number-named-call-deopt.js View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 10 months ago (2014-02-14 10:20:54 UTC) #1
Jakob Kummerow
lgtm
6 years, 10 months ago (2014-02-14 10:30:02 UTC) #2
Jarin
6 years, 10 months ago (2014-02-14 12:02:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698