chrome/browser/spellchecker/misspelling.cc - Issue 1665023002: Cheer up spell-checking code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/misspelling.cc

Issue 1665023002: Cheer up spell-checking code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/spellchecker/misspelling.cc

diff --git a/chrome/browser/spellchecker/misspelling.cc b/chrome/browser/spellchecker/misspelling.cc

index 86deb0d0674f0415b55867db078c9b8e111e9702..5f13a252be4771704f74cee975c9336acab5188b 100644

--- a/chrome/browser/spellchecker/misspelling.cc

+++ b/chrome/browser/spellchecker/misspelling.cc

@@ -48,8 +48,9 @@ Misspelling::Misspelling(const base::string16& context,

Misspelling::~Misspelling() {}

-base::DictionaryValue* SerializeMisspelling(const Misspelling& misspelling) {

- base::DictionaryValue* result = new base::DictionaryValue;

+scoped_ptr<base::DictionaryValue> SerializeMisspelling(

+ const Misspelling& misspelling) {

+ scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue);

result->SetString(

"timestamp",

base::Int64ToString(static_cast<long>(misspelling.timestamp.ToJsTime())));