Cheer up spell-checking code

chrome/browser/spellchecker/misspelling.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // An object to store user feedback to a single spellcheck suggestion.
 //
 // Stores the spellcheck suggestion, its uint32_t hash identifier, and user's
 // feedback. The feedback is indirect, in the sense that we record user's
 // |action| instead of asking them how they feel about a spellcheck suggestion.
 // The object can serialize itself.
 
 #ifndef CHROME_BROWSER_SPELLCHECKER_MISSPELLING_H_
 #define CHROME_BROWSER_SPELLCHECKER_MISSPELLING_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <vector>
 
+#include "base/memory/scoped_ptr.h"
 #include "base/time/time.h"
 #include "chrome/browser/spellchecker/spellcheck_action.h"
 
 // Stores user feedback to a spellcheck suggestion. Sample usage:
 //    Misspelling misspelling.
 //    misspelling.context = base::ASCIIToUTF16("Helllo world");
 //    misspelling.location = 0;
 //    misspelling.length = 6;
 //    misspelling.suggestions =
 //        std::vector<base::string16>(1, base::ASCIIToUTF16("Hello"));
@@ skipping 26 matching lines @@
   // The hash that identifies the misspelling.
   uint32_t hash;
 
   // User action.
   SpellcheckAction action;
 
   // The time when the user applied the action.
   base::Time timestamp;
 };
 
 // Serializes the data in this object into a dictionary value. The caller owns

[please use gerrit instead, 2016/02/03 23:59:10]

"The caller owns the result." is not necessary, as scoped_ptr<> now implies it.

[Kevin Bailey, 2016/02/04 16:34:11]

Done.

 // the result.
-base::DictionaryValue* SerializeMisspelling(const Misspelling& misspelling);
+scoped_ptr<base::DictionaryValue> SerializeMisspelling(
+    const Misspelling& misspelling);
 
 // Returns the substring of |context| that begins at |location| and contains
 // |length| characters.
 base::string16 GetMisspelledString(const Misspelling& misspelling);
 
 // Returns the approximate size of the misspelling when serialized.
 size_t ApproximateSerializedSize(const Misspelling& misspelling);
 
 #endif  // CHROME_BROWSER_SPELLCHECKER_MISSPELLING_H_