Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1664923002: Revert "Factor out xcode c/cpp settings into variables to apply to cmake builds." (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
herb_g, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Factor out xcode c/cpp settings into variables to apply to cmake builds." This reverts commit 32235eac4b5c625e639757b8247f6e64ce4dc4c8. This change should no longer be necessary now that gyp has been updated. Committed: https://skia.googlesource.com/skia/+/1aeac308093892ff2ae42fa228a69260a01b92ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -40 lines) Patch
M gyp/common_conditions.gypi View 3 chunks +16 lines, -39 lines 0 comments Download
M gyp/icu.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664923002/1
4 years, 10 months ago (2016-02-03 20:06:50 UTC) #4
bungeman-skia
To verify, update to the latest Skia, update your deps, apply this revert, re-gyp with ...
4 years, 10 months ago (2016-02-03 20:09:28 UTC) #6
bungeman-skia
4 years, 10 months ago (2016-02-03 20:13:07 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 20:35:03 UTC) #10
bsalomon
On 2016/02/03 20:35:03, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-02-03 21:03:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664923002/1
4 years, 10 months ago (2016-02-03 21:05:54 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 21:06:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1aeac308093892ff2ae42fa228a69260a01b92ff

Powered by Google App Engine
This is Rietveld 408576698