Chromium Code Reviews

Issue 1664883002: [wasm] Refactor handling of operands to bytecodes. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Refactor handling of operands to bytecodes. This cleans up and simplifyies handling the bytes followin an opcode with little helper structs that will be useful in the interpreter and already have been in keeping OpcodeArity and OpcodeLength up to date with the decoder. R=bradnelson@chromium.org, ahaas@chromium.org BUG= Committed: https://crrev.com/9c006b724ee2a094b57ffcdf2cd0da060af1f821 Cr-Commit-Position: refs/heads/master@{#33723}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Stats (+561 lines, -374 lines)
M src/wasm/ast-decoder.h View 4 chunks +153 lines, -3 lines 0 comments
M src/wasm/ast-decoder.cc View 23 chunks +327 lines, -354 lines 0 comments
M src/wasm/decoder.h View 2 chunks +68 lines, -0 lines 0 comments
M test/unittests/wasm/ast-decoder-unittest.cc View 3 chunks +13 lines, -17 lines 0 comments

Messages

Total messages: 9 (3 generated)
titzer
4 years, 10 months ago (2016-02-03 19:15:57 UTC) #1
bradnelson
lgtm https://codereview.chromium.org/1664883002/diff/1/src/wasm/ast-decoder.cc File src/wasm/ast-decoder.cc (right): https://codereview.chromium.org/1664883002/diff/1/src/wasm/ast-decoder.cc#newcode665 src/wasm/ast-decoder.cc:665: len = 1 + operand.length; FWIW, the bookkeeping ...
4 years, 10 months ago (2016-02-03 19:44:48 UTC) #2
titzer
https://codereview.chromium.org/1664883002/diff/1/src/wasm/ast-decoder.cc File src/wasm/ast-decoder.cc (right): https://codereview.chromium.org/1664883002/diff/1/src/wasm/ast-decoder.cc#newcode665 src/wasm/ast-decoder.cc:665: len = 1 + operand.length; On 2016/02/03 19:44:47, bradnelson ...
4 years, 10 months ago (2016-02-04 09:34:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664883002/40001
4 years, 10 months ago (2016-02-04 10:03:29 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-04 10:16:24 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 10:16:55 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9c006b724ee2a094b57ffcdf2cd0da060af1f821
Cr-Commit-Position: refs/heads/master@{#33723}

Powered by Google App Engine