Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1664863002: base: Fix copy contructor SharedMemoryHandle. (Closed)

Created:
4 years, 10 months ago by erikchen
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Fix copy contructor in SharedMemoryHandle. Forgot to correctly update the copy constructor with the new parameter ownership_passes_to_ipc_. BUG=580636 Committed: https://crrev.com/c69156f56bb81c515b0f9a20ed1c1689df034912 Cr-Commit-Position: refs/heads/master@{#373298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/memory/shared_memory_handle_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
erikchen
mark: Please review.
4 years, 10 months ago (2016-02-03 18:15:10 UTC) #3
Mark Mentovai
LGTM
4 years, 10 months ago (2016-02-03 18:16:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664863002/1
4 years, 10 months ago (2016-02-03 18:17:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 19:22:36 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 19:24:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c69156f56bb81c515b0f9a20ed1c1689df034912
Cr-Commit-Position: refs/heads/master@{#373298}

Powered by Google App Engine
This is Rietveld 408576698