Issue 166483011: Add --trace-frame-viewer as a safer alternative to --trace-cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166483011: Add --trace-frame-viewer as a safer alternative to --trace-cc (Closed)

Created:
6 years, 10 months ago by nduca

Modified:
6 years, 10 months ago

Reviewers:
Sami, Sami (do not use)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add --trace-frame-viewer as a safer alternative to --trace-cc --trace-cc implied cc.debug* which enables a ton of stuff for ubercompositor. This is bad for recording performance. In the vast majority of use cases, users of adb_profile_chrome just want a basic frame viewer-case. So rename the flags accordingly to facilitate that use case. R=skyostil Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251673