Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 166483007: Add Installer.InstallDateProvisioningSource metric. (Closed)

Created:
6 years, 10 months ago by zeuthen
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add Installer.InstallDateProvisioningSource metric. This metric was added to update_engine to track how the install-date-days variable is calculated. BUG=chromium:336838 TEST=Validated the xml, pretty print succeeded. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252110

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
zeuthen
Hi, adding sosa@ for functional review and jar@ and/or isherman@ for OWNERS. Thanks!
6 years, 10 months ago (2014-02-14 21:45:52 UTC) #1
sosa
lgtm
6 years, 10 months ago (2014-02-14 23:05:02 UTC) #2
Ilya Sherman
LGTM % nits: https://codereview.chromium.org/166483007/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/166483007/diff/1/tools/metrics/histograms/histograms.xml#newcode6035 tools/metrics/histograms/histograms.xml:6035: + uprading to a version with ...
6 years, 10 months ago (2014-02-14 23:09:57 UTC) #3
zeuthen
Thanks for the review - new CL on its way! https://codereview.chromium.org/166483007/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/166483007/diff/1/tools/metrics/histograms/histograms.xml#newcode6035 ...
6 years, 10 months ago (2014-02-14 23:24:55 UTC) #4
Ilya Sherman
LGTM
6 years, 10 months ago (2014-02-14 23:28:03 UTC) #5
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 10 months ago (2014-02-14 23:28:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeuthen@chromium.org/166483007/70001
6 years, 10 months ago (2014-02-14 23:41:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 01:24:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-15 01:24:14 UTC) #9
zeuthen
The CQ bit was checked by zeuthen@chromium.org
6 years, 10 months ago (2014-02-18 18:32:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeuthen@chromium.org/166483007/70001
6 years, 10 months ago (2014-02-18 18:35:46 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 18:36:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 18:36:17 UTC) #13
zeuthen
The CQ bit was checked by zeuthen@chromium.org
6 years, 10 months ago (2014-02-19 19:24:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeuthen@chromium.org/166483007/70001
6 years, 10 months ago (2014-02-19 19:36:23 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 22:10:03 UTC) #16
Message was sent while issue was closed.
Change committed as 252110

Powered by Google App Engine
This is Rietveld 408576698