Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 1664763003: Rename QUIC connection timeout error codes to be more descriptive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113275797
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index 30327524cd845f59183956eb1cf66be16662f4c3..d6bc44990e04d96e29191b6cb58c0fa7aa63010d 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -2487,7 +2487,7 @@ TEST_P(QuicStreamFactoryTest, TimeoutsWithOpenStreamsTwoOfTwo) {
DVLOG(1)
<< "Created 1st session and initialized a stream. Now trigger timeout";
- session->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false);
+ session->connection()->CloseConnection(QUIC_NETWORK_IDLE_TIMEOUT, false);
// Need to spin the loop now to ensure that
// QuicStreamFactory::OnSessionClosed() runs.
base::RunLoop run_loop;
@@ -2513,7 +2513,7 @@ TEST_P(QuicStreamFactoryTest, TimeoutsWithOpenStreamsTwoOfTwo) {
EXPECT_EQ(OK, stream2->InitializeStream(&request_info, DEFAULT_PRIORITY,
net_log_, CompletionCallback()));
- session2->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false);
+ session2->connection()->CloseConnection(QUIC_NETWORK_IDLE_TIMEOUT, false);
// Need to spin the loop now to ensure that
// QuicStreamFactory::OnSessionClosed() runs.
base::RunLoop run_loop2;
@@ -2698,7 +2698,7 @@ TEST_P(QuicStreamFactoryTest, TimeoutsWithOpenStreamsTwoOfThree) {
DVLOG(1)
<< "Created 1st session and initialized a stream. Now trigger timeout";
- session->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false);
+ session->connection()->CloseConnection(QUIC_NETWORK_IDLE_TIMEOUT, false);
// Need to spin the loop now to ensure that
// QuicStreamFactory::OnSessionClosed() runs.
base::RunLoop run_loop;
@@ -2744,7 +2744,7 @@ TEST_P(QuicStreamFactoryTest, TimeoutsWithOpenStreamsTwoOfThree) {
EXPECT_TRUE(stream3.get());
EXPECT_EQ(OK, stream3->InitializeStream(&request_info, DEFAULT_PRIORITY,
net_log_, CompletionCallback()));
- session3->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false);
+ session3->connection()->CloseConnection(QUIC_NETWORK_IDLE_TIMEOUT, false);
// Need to spin the loop now to ensure that
// QuicStreamFactory::OnSessionClosed() runs.
base::RunLoop run_loop3;
@@ -2807,7 +2807,7 @@ TEST_P(QuicStreamFactoryTest, DisableQuicWhenTimeoutsWithOpenStreams) {
DVLOG(1)
<< "Created 1st session and initialized a stream. Now trigger timeout."
<< "Will disable QUIC.";
- session->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false);
+ session->connection()->CloseConnection(QUIC_NETWORK_IDLE_TIMEOUT, false);
// Need to spin the loop now to ensure that
// QuicStreamFactory::OnSessionClosed() runs.
base::RunLoop run_loop;
@@ -3024,7 +3024,7 @@ TEST_P(QuicStreamFactoryTest, TimeoutsWithOpenStreamsTwoOfFour) {
DVLOG(1)
<< "Created 1st session and initialized a stream. Now trigger timeout";
- session->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false);
+ session->connection()->CloseConnection(QUIC_NETWORK_IDLE_TIMEOUT, false);
// Need to spin the loop now to ensure that
// QuicStreamFactory::OnSessionClosed() runs.
base::RunLoop run_loop;
@@ -3087,7 +3087,7 @@ TEST_P(QuicStreamFactoryTest, TimeoutsWithOpenStreamsTwoOfFour) {
EXPECT_TRUE(stream4.get());
EXPECT_EQ(OK, stream4->InitializeStream(&request_info, DEFAULT_PRIORITY,
net_log_, CompletionCallback()));
- session4->connection()->CloseConnection(QUIC_CONNECTION_TIMED_OUT, false);
+ session4->connection()->CloseConnection(QUIC_NETWORK_IDLE_TIMEOUT, false);
// Need to spin the loop now to ensure that
// QuicStreamFactory::OnSessionClosed() runs.
base::RunLoop run_loop4;
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698