Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: net/websockets/websocket_event_interface.h

Issue 1664743002: [OBSOLETE][DO NOT SUBMIT][DO NOT COMMIT]] Browser-side implementation of WebSocket Blob receive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@websocket_blob_send_sender
Patch Set: Now actually works. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/websockets/websocket_channel.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/websockets/websocket_event_interface.h
diff --git a/net/websockets/websocket_event_interface.h b/net/websockets/websocket_event_interface.h
index 25e12a057e9e9a55682021457c203207cb7e4317..970e344372094ba2dbcc00891100c77c10654410 100644
--- a/net/websockets/websocket_event_interface.h
+++ b/net/websockets/websocket_event_interface.h
@@ -75,8 +75,9 @@ class NET_EXPORT WebSocketEventInterface {
// The channel should not be used again after OnDropChannel() has been
// called.
//
- // This method returns a ChannelState for consistency, but all implementations
- // must delete the Channel and return CHANNEL_DELETED.
+ // Implementations that delete the channel synchronously should return
+ // CHANNEL_DELETED. It is valid to return CHANNEL_ALIVE and delete the
+ // channel after a delay, provided no further calls are made on the channel.
virtual ChannelState OnDropChannel(bool was_clean,
uint16_t code,
const std::string& reason)
« no previous file with comments | « net/websockets/websocket_channel.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698