build/config/compiler/BUILD.gn - Issue 1664693004: GN: Set -fstack-protector for arm64 to match GYP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1664693004: GN: Set -fstack-protector for arm64 to match GYP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 8ddbf7ed8aa6cf3f853a371a3f26bb9d79b0bc4a..c703b2290eab3f8515d1eaebab2ae856948a3786 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -163,7 +163,7 @@ config("compiler") {

} else if (is_posix && !is_chromeos && !is_nacl) {

# TODO(phajdan.jr): Use -fstack-protector-strong when our gcc supports it.

cflags += [ "--param=ssp-buffer-size=4" ]

- if (is_android && (current_cpu == "arm64" || current_cpu == "x86")) {

agrieve 2016/02/04 02:15:47 Hmm, yeah, i got nothing :(. Could you also add t

+ if (is_android && current_cpu == "x86") {

cflags += [ "-fno-stack-protector" ]

} else {

cflags += [ "-fstack-protector" ]

« no previous file with comments | « no previous file | no next file » | no next file with comments »