Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1664683002: Expect JSReceiver in Runtime_DeleteLookupSlot, not just JSObject. (Closed)

Created:
4 years, 10 months ago by neis
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expect JSReceiver in Runtime_DeleteLookupSlot, not just JSObject. BUG=chromium:583260 LOG=n Committed: https://crrev.com/a973f734657f1cd24686768995a03b2d29537f7c Cr-Commit-Position: refs/heads/master@{#33697}

Patch Set 1 #

Patch Set 2 : Blacklist regression test for ignition (no with support) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/runtime/runtime-scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-583260.js View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
neis
ptal
4 years, 10 months ago (2016-02-03 08:06:52 UTC) #3
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-03 08:50:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664683002/1
4 years, 10 months ago (2016-02-03 08:52:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/14789)
4 years, 10 months ago (2016-02-03 09:10:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664683002/20001
4 years, 10 months ago (2016-02-03 09:18:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 09:49:09 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 09:49:32 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a973f734657f1cd24686768995a03b2d29537f7c
Cr-Commit-Position: refs/heads/master@{#33697}

Powered by Google App Engine
This is Rietveld 408576698