Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: testing/test.gni

Issue 1664653003: Revert of Move gn _run target generation into test(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index 1c2a927717f99bd565aaa2db1ed20d0919b2f263..acd1e1acab3408cca6403648d5efa88f4212caeb 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -186,8 +186,6 @@
]
}
} else {
- main_target_name = target_name
-
executable(target_name) {
forward_variables_from(invoker, "*")
@@ -205,14 +203,5 @@
"//build/win:default_exe_manifest",
]
}
-
- # TODO(GYP): Delete this after we've converted everything to GN.
- # The _run targets exist only for compatibility with GYP.
- group("${target_name}_run") {
- testonly = true
- deps = [
- ":$main_target_name",
- ]
- }
}
}
« no previous file with comments | « sync/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698