Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: testing/test.gni

Issue 1664653003: Revert of Move gn _run target generation into test(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================================================== 5 # ==============================================================================
6 # TEST SETUP 6 # TEST SETUP
7 # ============================================================================== 7 # ==============================================================================
8 8
9 # Define a test as an executable (or apk on Android) with the "testonly" flag 9 # Define a test as an executable (or apk on Android) with the "testonly" flag
10 # set. 10 # set.
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 } else { 179 } else {
180 deps = [] 180 deps = []
181 } 181 }
182 deps += [ 182 deps += [
183 # All shared libraries must have the sanitizer deps to properly link in 183 # All shared libraries must have the sanitizer deps to properly link in
184 # asan mode (this target will be empty in other cases). 184 # asan mode (this target will be empty in other cases).
185 "//build/config/sanitizers:deps", 185 "//build/config/sanitizers:deps",
186 ] 186 ]
187 } 187 }
188 } else { 188 } else {
189 main_target_name = target_name
190
191 executable(target_name) { 189 executable(target_name) {
192 forward_variables_from(invoker, "*") 190 forward_variables_from(invoker, "*")
193 191
194 testonly = true 192 testonly = true
195 193
196 if (!defined(invoker.deps)) { 194 if (!defined(invoker.deps)) {
197 deps = [] 195 deps = []
198 } 196 }
199 deps += [ 197 deps += [
200 # All shared libraries must have the sanitizer deps to properly link in 198 # All shared libraries must have the sanitizer deps to properly link in
201 # asan mode (this target will be empty in other cases). 199 # asan mode (this target will be empty in other cases).
202 "//build/config/sanitizers:deps", 200 "//build/config/sanitizers:deps",
203 201
204 # Give tests the default manifest on Windows (a no-op elsewhere). 202 # Give tests the default manifest on Windows (a no-op elsewhere).
205 "//build/win:default_exe_manifest", 203 "//build/win:default_exe_manifest",
206 ] 204 ]
207 } 205 }
208
209 # TODO(GYP): Delete this after we've converted everything to GN.
210 # The _run targets exist only for compatibility with GYP.
211 group("${target_name}_run") {
212 testonly = true
213 deps = [
214 ":$main_target_name",
215 ]
216 }
217 } 206 }
218 } 207 }
OLDNEW
« no previous file with comments | « sync/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698