Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 16646002: Move the CSS Device Adaptation @viewport rule support behind a runtime flag (Closed)

Created:
7 years, 6 months ago by kenneth.r.christiansen
Modified:
7 years, 6 months ago
CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, bevc, rune
Visibility:
Public.

Description

Move the CSS Device Adaptation @viewport rule support behind a runtime flag As this is an experimental feature it is not enabled for stable releases, but it is enabled for testing purposes or by using the flag --enable-experimental-webkit-features and --enable-viewport to the content_shell Unprefix the CSSOM interface. The style rule will be unprefixed separately as it affects all the tests Some tests are failing now due to some changes in the tests/spec which were added in another commit. This will be fixed in a separate patch. initialViewportSize was not used by Chromium (leftover from WebKit). Hook it up directly. BUG=235457, 155477 R=alexis.menard@intel.com, apavlov@chromium.org, johnme@chromium.org, marja@chromium.org, peter@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152152

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1

Patch Set 8 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -159 lines) Patch
M LayoutTests/css3/device-adapt/opera/cascading-001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-002-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-003-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-004-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-002-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-003-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-004-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-005-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-007-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-008-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-009-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-010-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-011-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-012-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-013-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-014-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-015-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-016-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-017-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-018-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-019-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/cssom-001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-001-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-002-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-003-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-004-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-005-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-006-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-007-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-002-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-003-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSRuleCustom.cpp View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSGrammar.y.in View 1 2 3 5 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/CSSParser.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 2 3 9 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSRule.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSRule.cpp View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSRule.idl View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSViewportRule.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSViewportRule.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSViewportRule.idl View 1 2 3 4 5 6 7 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/css/StyleRule.h View 4 chunks +1 line, -7 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 6 chunks +3 lines, -11 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 4 chunks +2 lines, -10 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 2 3 4 3 chunks +2 lines, -5 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/features.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/FrameView.h View 1 2 3 4 5 2 chunks +1 line, -10 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
kenneth.r.christiansen
7 years, 6 months ago (2013-06-09 11:00:45 UTC) #1
rune
https://codereview.chromium.org/16646002/diff/12001/Source/core/page/FrameView.h File Source/core/page/FrameView.h (left): https://codereview.chromium.org/16646002/diff/12001/Source/core/page/FrameView.h#oldcode544 Source/core/page/FrameView.h:544: #endif Is m_initialViewportSize used anymore?
7 years, 6 months ago (2013-06-10 07:35:18 UTC) #2
Peter Beverloo
This looks fine to me. Be sure to give John a chance to check your ...
7 years, 6 months ago (2013-06-10 11:01:01 UTC) #3
Peter Beverloo
Also, please refer to a bug in your CL description. 235457 or 155477 can be ...
7 years, 6 months ago (2013-06-10 11:02:44 UTC) #4
kenneth.r.christiansen
> It's a little bit confusing that you unprefix part of the implementation > (WebKitCSSViewportRule ...
7 years, 6 months ago (2013-06-10 11:03:10 UTC) #5
darktears
lgtm but I'd like someone else to make the final approval. https://codereview.chromium.org/16646002/diff/20001/Source/core/css/CSSViewportRule.idl File Source/core/css/CSSViewportRule.idl (right): ...
7 years, 6 months ago (2013-06-10 12:43:01 UTC) #6
Peter Beverloo
lgtm (but not an owner either) for the change itself, thank you for the additional ...
7 years, 6 months ago (2013-06-10 14:02:13 UTC) #7
johnme
lgtm, though I'm relying on others for the CSS parsing bits as I'm less familiar ...
7 years, 6 months ago (2013-06-10 14:13:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/16646002/38001
7 years, 6 months ago (2013-06-10 14:16:58 UTC) #9
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1395
7 years, 6 months ago (2013-06-10 14:28:54 UTC) #10
apavlov
lgtm
7 years, 6 months ago (2013-06-10 14:42:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/16646002/38001
7 years, 6 months ago (2013-06-10 14:42:13 UTC) #12
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1400
7 years, 6 months ago (2013-06-10 14:53:52 UTC) #13
kenneth.r.christiansen
7 years, 6 months ago (2013-06-10 15:46:05 UTC) #14
marja
Source/bindings/v8/custom/V8CSSRuleCustom.cpp lgtm
7 years, 6 months ago (2013-06-10 16:23:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/16646002/38001
7 years, 6 months ago (2013-06-10 16:24:36 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=9401
7 years, 6 months ago (2013-06-10 18:29:44 UTC) #17
kenneth.r.christiansen
7 years, 6 months ago (2013-06-10 19:17:54 UTC) #18
Message was sent while issue was closed.
Committed patchset #8 manually as r152152 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698