[Interpreter] Adds support for rest parameters to interpreter.

[Interpreter] Adds support for rest parameters to interpreter.

Adds implementation and tests for rest parameters to interpreter.

BUG=v8:4280, v8:4683
LOG=N

Committed: https://crrev.com/9aa612cb2cd0e056cd1885f450fd4bf35cb1d10d
Cr-Commit-Position: refs/heads/master@{#33722}

[mythria, 2016-02-03 11:40:56]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 11:40:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664593003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664593003/20001

[commit-bot: I haz the power, 2016-02-03 11:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 11:53:31]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/14904)

[mythria, 2016-02-03 12:44:35]

mythria@chromium.org changed reviewers:
+ mstarzinger@chromium.org, rmcilroy@chromium.org

[mythria, 2016-02-03 12:44:36]

Michi, could you review changes to bytecode-graph-builder.cc
Ross, PTAL.

Thanks,
Mythri

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:615: DCHECK_EQ(index_entry, 0);
I will change it to DCHECK(FitsInIdx8Operand(index_entry)), if this check is too
strict. This check will fail if CreateArguments requires a constant pool entry
in future.

[mythria, 2016-02-03 12:44:41]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 12:44:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664593003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664593003/40001

[commit-bot: I haz the power, 2016-02-03 13:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 13:09:51]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-02-03 14:00:56]

LGTM with a couple of comments.

https://codereview.chromium.org/1664593003/diff/40001/src/compiler/bytecode-g...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1664593003/diff/40001/src/compiler/bytecode-g...
src/compiler/bytecode-graph-builder.cc:1020: CreateArgumentsParameters::Type
type, int index) {
/s/index/rest_index

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:612: // This would always be the first
entry in the constant pool, since rest
/s/would/will

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:612: // This would always be the first
entry in the constant pool, since rest
/s/since rest/since the rest/

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:613: // arguments object is created at
the start of function just after creating
/s/function/the function/

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:614: // arguments object.
/s/arguments/the arguments

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:615: DCHECK_EQ(index_entry, 0);
On 2016/02/03 12:44:36, mythria wrote:
> I will change it to DCHECK(FitsInIdx8Operand(index_entry)), if this check is
too
> strict. This check will fail if CreateArguments requires a constant pool entry
> in future.

Yes please do that, but also make it a CHECK rather than a DCHECK

[Michael Starzinger, 2016-02-03 15:19:30]

LGTM on "compiler".

[mythria, 2016-02-03 15:56:16]

Thanks, fixed all nits.

https://codereview.chromium.org/1664593003/diff/40001/src/compiler/bytecode-g...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1664593003/diff/40001/src/compiler/bytecode-g...
src/compiler/bytecode-graph-builder.cc:1020: CreateArgumentsParameters::Type
type, int index) {
On 2016/02/03 14:00:56, rmcilroy wrote:
> /s/index/rest_index

Done.

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:612: // This would always be the first
entry in the constant pool, since rest
On 2016/02/03 14:00:56, rmcilroy wrote:
> /s/since rest/since the rest/

Done.

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:612: // This would always be the first
entry in the constant pool, since rest
On 2016/02/03 14:00:56, rmcilroy wrote:
> /s/would/will

Done.

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:613: // arguments object is created at
the start of function just after creating
On 2016/02/03 14:00:56, rmcilroy wrote:
> /s/function/the function/

Done.

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:614: // arguments object.
On 2016/02/03 14:00:56, rmcilroy wrote:
> /s/arguments/the arguments

Done.

https://codereview.chromium.org/1664593003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:615: DCHECK_EQ(index_entry, 0);
On 2016/02/03 14:00:56, rmcilroy wrote:
> On 2016/02/03 12:44:36, mythria wrote:
> > I will change it to DCHECK(FitsInIdx8Operand(index_entry)), if this check is
> too
> > strict. This check will fail if CreateArguments requires a constant pool
entry
> > in future.
> 
> Yes please do that, but also make it a CHECK rather than a DCHECK

Done.

[mythria, 2016-02-03 15:58:54]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 15:58:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664593003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664593003/60001

[commit-bot: I haz the power, 2016-02-03 16:01:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 16:01:27]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/2291)

[mythria, 2016-02-04 09:06:34]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 09:06:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664593003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664593003/60001

[commit-bot: I haz the power, 2016-02-04 09:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 09:28:58]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-02-04 09:52:55]

The CQ bit was checked by mythria@chromium.org

[mythria, 2016-02-04 09:52:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1664593003/#ps60001
(title: "Fixes comments.")

[commit-bot: I haz the power, 2016-02-04 09:53:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664593003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664593003/60001

[commit-bot: I haz the power, 2016-02-04 10:02:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-04 10:03:20]

Description was changed from

==========
[Interpreter] Adds support for rest parameters to interpreter.

Adds implementation and tests for rest parameters to interpreter.

BUG=v8:4280,v8:4683
LOG=N
==========

to

==========
[Interpreter] Adds support for rest parameters to interpreter.

Adds implementation and tests for rest parameters to interpreter.

BUG=v8:4280,v8:4683
LOG=N

Committed: https://crrev.com/9aa612cb2cd0e056cd1885f450fd4bf35cb1d10d
Cr-Commit-Position: refs/heads/master@{#33722}
==========

[commit-bot: I haz the power, 2016-02-04 10:03:22]

Patchset 4 (id:??) landed as
https://crrev.com/9aa612cb2cd0e056cd1885f450fd4bf35cb1d10d
Cr-Commit-Position: refs/heads/master@{#33722}