test/descriptor.dart - Issue 1664563002: Refactor test servers to make them less global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/descriptor.dart

Issue 1664563002: Refactor test servers to make them less global. (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/descriptor.dart

diff --git a/test/descriptor.dart b/test/descriptor.dart

index be7cb71a6116626cdf20f214bcc5e160dba060aa..b9a28b36c4a395da0a296bc607ae42d4ff89049a 100644

--- a/test/descriptor.dart

+++ b/test/descriptor.dart

@@ -153,7 +153,7 @@ Descriptor cacheDir(Map packages, {bool includePubspecs: false}) {

Descriptor hostedCache(Iterable<Descriptor> contents) {

return dir(cachePath, [

dir('hosted', [

- async(port.then((p) => dir('localhost%58$p', contents)))

+ async(globalServer.port.then((p) => dir('localhost%58$p', contents)))

])

]);

}

« no previous file with comments | « test/cache/repair/reinstalls_hosted_packages_test.dart ('k') | test/descriptor_server.dart » ('j') | no next file with comments »