Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1664543005: Kill CFX_PtryArray in CXFA_FWLAdapterTimerMgr. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Stale iterator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -39 lines) Patch
M fpdfsdk/include/fpdfxfa/fpdfxfa_util.h View 3 chunks +9 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp View 1 1 chunk +19 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Pls review.
4 years, 10 months ago (2016-02-04 19:16:13 UTC) #1
Lei Zhang
lgtm but please address the comment below: https://codereview.chromium.org/1664543005/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp (right): https://codereview.chromium.org/1664543005/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp#newcode35 fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp:35: delete *it; ...
4 years, 10 months ago (2016-02-04 20:03:24 UTC) #2
Tom Sepez
https://codereview.chromium.org/1664543005/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp (right): https://codereview.chromium.org/1664543005/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp#newcode35 fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp:35: delete *it; On 2016/02/04 20:03:24, Lei Zhang wrote: > ...
4 years, 10 months ago (2016-02-04 20:26:11 UTC) #3
Tom Sepez
4 years, 10 months ago (2016-02-04 21:13:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f6488cdb6633cd4b32fe08fb124f19c20b3afb59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698