Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1664523002: Fix FrameOwnerPropertiesPropagationScrolling on 10.6 after r372906 (Closed)

Created:
4 years, 10 months ago by tapted
Modified:
4 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix FrameOwnerPropertiesPropagationScrolling on 10.6 after r372906 10.6 wouldn't have swizzled anything, and can't call +[NSScroller preferredScrollerStyle] BUG=None TBR=ahest@yandex-team.ru Committed: https://crrev.com/ec2648c1e68a6fdcdfa1ae3a6febe357973cdc1a Cr-Commit-Position: refs/heads/master@{#373102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/base/test/scoped_preferred_scroller_style_legacy_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msw
rubber stamp lgtm to hopefully fix SitePerProcessBrowserTest.FrameOwnerPropertiesPropagationScrolling on Mac10.6 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/11632
4 years, 10 months ago (2016-02-02 23:23:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664523002/1
4 years, 10 months ago (2016-02-02 23:29:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 00:42:59 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec2648c1e68a6fdcdfa1ae3a6febe357973cdc1a Cr-Commit-Position: refs/heads/master@{#373102}
4 years, 10 months ago (2016-02-03 00:44:35 UTC) #10
tapted
On 2016/02/02 23:23:37, msw wrote: > rubber stamp lgtm to hopefully fix > SitePerProcessBrowserTest.FrameOwnerPropertiesPropagationScrolling > ...
4 years, 10 months ago (2016-02-03 03:18:17 UTC) #11
msw
4 years, 10 months ago (2016-02-03 03:21:39 UTC) #12
Message was sent while issue was closed.
On 2016/02/03 03:18:17, tapted wrote:
> On 2016/02/02 23:23:37, msw wrote:
> > rubber stamp lgtm to hopefully fix
> > SitePerProcessBrowserTest.FrameOwnerPropertiesPropagationScrolling
> > on Mac10.6 Tests:
> >
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/11632
> 
> Green again in
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/11663
> \o/

Yup; thanks for the quick fix!

Powered by Google App Engine
This is Rietveld 408576698