Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1664513007: [i18n] Replace uses of %_Arguments/%_ArgumentsLength with arguments. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[i18n] Replace uses of %_Arguments/%_ArgumentsLength with arguments. No need to micro-optimize here, and in almost all cases here, using arguments should result in roughly the same code w/ Crankshaft anyway. R=yangguo@chromium.org Committed: https://crrev.com/db74cccf8a7afc94d89e95eff180d67a93e0da89 Cr-Commit-Position: refs/heads/master@{#33716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M src/js/i18n.js View 15 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-04 06:18:47 UTC) #1
Yang
LGTM, but... wouldn't it be easier to use normal function parameters for those arguments and ...
4 years, 10 months ago (2016-02-04 06:45:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664513007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664513007/1
4 years, 10 months ago (2016-02-04 06:50:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 06:51:29 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 06:51:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db74cccf8a7afc94d89e95eff180d67a93e0da89
Cr-Commit-Position: refs/heads/master@{#33716}

Powered by Google App Engine
This is Rietveld 408576698